Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds POST method support for the /api/v1/search endpoint, allowing clients to submit search parameters via JSON request body instead of URL query parameters. This provides a more ergonomic API for complex filter objects.
- Added
SearchRequestPOSTstruct andsearch_jsonendpoint handler for POST requests - Refactored search logic into shared
search_internalfunction used by both GET and POST - Updated documentation to explain both GET and POST usage patterns with examples
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/routes/search.rs | Added POST endpoint with SearchRequestPOST struct, refactored shared logic into search_internal |
| server/src/server.rs | Registered new search_json route handler |
| server/tests/tests.rs | Added test coverage for POST search endpoint with filters |
| docs/server/api/search.md | Updated documentation to cover both GET and POST methods with examples |
| core/src/query.rs | Fixed punctuation in error message (added period) |
| core/src/init.rs | Changed vec! to array literal and removed format! macro call |
| .gitignore | Added .vscode directory to gitignore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL query parameters can get unwieldy, so provide an equivalent way to search using POST w/ json in body.